On 03/26/2012 04:28 AM, Julian Calaby wrote: > Hi Paul, > > On Mon, Mar 26, 2012 at 12:20, Paul Gortmaker > <paul.gortmaker@xxxxxxxxxxxxx> wrote: >> [Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device] On 26/03/2012 (Mon 11:13) Julian Calaby wrote: >> >>> Hi Paul, >>> >>> On Mon, Mar 26, 2012 at 11:02, Paul Gortmaker >>> <paul.gortmaker@xxxxxxxxxxxxx> wrote: >>>> The following is seen during allmodconfig builds for MIPS: >>>> >>>> drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration >>>> of function 'pcibios_enable_device' [-Werror=implicit-function-declaration] >>>> cc1: some warnings being treated as errors >>>> make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1 >>>> >>>> Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf >>>> >>>> "bcma: add PCIe host controller" >>>> >>>> Add the header instead of implicitly assuming it will be present. >>>> Sounds like a good idea, but that alone doesn't fix anything. >>>> >>>> The real problem is that the Kconfig has settings related to whether >>>> PCI is possible, i.e. >>>> >>>> config BCMA_HOST_PCI_POSSIBLE >>>> bool >>>> depends on BCMA && PCI = y >>>> default y >>>> >>>> config BCMA_HOST_PCI >>>> bool "Support for BCMA on PCI-host bus" >>>> depends on BCMA_HOST_PCI_POSSIBLE >>>> >>>> ...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't >>>> have any dependencies on the above. Add one. >>>> >>>> CC: Hauke Mehrtens <hauke@xxxxxxxxxx> >>>> CC: John W. Linville <linville@xxxxxxxxxxxxx> >>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> >>>> >>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >>>> index c1172da..fb7c80f 100644 >>>> --- a/drivers/bcma/Kconfig >>>> +++ b/drivers/bcma/Kconfig >>>> @@ -29,7 +29,7 @@ config BCMA_HOST_PCI >>>> >>>> config BCMA_DRIVER_PCI_HOSTMODE >>>> bool "Driver for PCI core working in hostmode" >>>> - depends on BCMA && MIPS >>>> + depends on BCMA && MIPS && BCMA_HOST_PCI >>> >>> I don't know the hardware, but I'm sure there'd be situations >>> (probably for embedded devices) where hostmode would be wanted without >>> the PCI host support - so shouldn't this depend on >>> BCMA_HOST_PCI_POSSIBLE? >> >> My reading of things is that BCMA_HOST_PCI is equivalent to, or >> at most a subset of BCMA_HOST_PCI_POSSIBLE. But if the maintainers >> want to tweak things accordingly, then great -- I'm just reporting >> what I see in build failures. > > That's not the case. > > BCMA_HOST_PCI is a separate config option that depends on > ...._POSSIBLE but is user selectable. ...._POSSIBLE isn't user > selectable and is automatically "y" when the conditions for PCI > support for BCMA are true. > > Thanks, > Yes that's correct. BCMA_HOST_PCI_POSSIBLE is used to only show BCMA_DRIVER_PCI_HOSTMODE if PCI is enabled. For now you are not able to use PCI host mode without also supporting client mode in bcma. I have only seen device where an other bcma based device was being behind the PCIe link. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
