Search Linux Wireless

RE: [RFC] [PATCH] NFC: The core part should generate the target index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Samuel,
 
> Ilan, could you please comment on this patch and also make 
> sure that it
> doesn't break multiple targets support for NCI ?
It seems to me that this patch doesn't break multiple targets support for NCI.

> diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c
> index 5a839ce..47fcf0d 100644
> --- a/net/nfc/rawsock.c
> +++ b/net/nfc/rawsock.c
> @@ -92,6 +92,18 @@ static int rawsock_connect(struct socket 
> *sock, struct sockaddr *_addr,
>  		goto error;
>  	}
>  
> +	if (addr->target_idx > dev->target_idx - 1 ||
> +	    addr->target_idx < dev->target_idx - dev->n_targets) {
> +		rc = -EINVAL;
> +		goto error;
> +	}
> +
> +	if (addr->target_idx > dev->target_idx - 1 ||
> +	    addr->target_idx < dev->target_idx - dev->n_targets) {
> +		rc = -EINVAL;
> +		goto error;
> +	}
> +
It looks like the 'if' statement you added appears twice.

Thanks & BR,
Ilan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux