Search Linux Wireless

Re: [PATCH] ath6kl: Dump htc header when invalid Rx frame length is detected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/21/2012 11:11 AM, Vasanthakumar Thiagarajan wrote:
> Dump htc header along with the warning message when the request
> to Rx with invalid frame length is detected.
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@xxxxxxxxxxxxxxxx>

[...]

> -		ath6kl_warn("Rx buffer requested with invalid length\n");
> +		ath6kl_warn("Rx buffer requested with invalid length"
> +			    "htc_hdr:eid - %d, flags - 0x%x, len - %d\n",

No need to split the format string, that's an exception to the long line
rule. Also please minimise the message a bit:

"Rx buffer requested with invalid length htc_hdr: eid %d flags 0x%x len
%d\n"

I try to keep the log messages as small as possible so that they are
easier to read.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux