Search Linux Wireless

Re: [PATCH wireless-next 2/3] ath5k: Introduce _ath5k_printk to reduce code/text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18 March 2012 22:18, Joe Perches <joe@xxxxxxxxxxx> wrote:

>> Otherwise compiling in debugging will cause a _lot_ of spurious
>> register reads to occur that are then tossed. This was one of the big
>> reasons for instability and slow performance when AH_DEBUG was
>> enabled.
>
> That doesn't make any sense in this case.
>
> It's either a call to printk or _ath5_printk
> but it's still a call to a function.

The FreeBSD HAL used to be like this. I changed it so it didn't
evaluate the arguments before it figured out whether or not to do the
(k)printf().

I'm just pointing it out as you're (currently) knee deep in the
debugging code and it may be useful for you to also think about
implementing.


adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux