Search Linux Wireless

Re: [RFC] mac80211: fix possible tid_rx->reorder_timer use after free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 19, 2012 at 02:49:54PM +0100, Johannes Berg wrote:
> On Mon, 2012-03-19 at 14:43 +0100, Stanislaw Gruszka wrote:
> > On Mon, Mar 19, 2012 at 02:07:57PM +0100, Johannes Berg wrote:
> > > I was actually thinking of using just del_timer(), but now that I think
> > > about it, should anything prevent us from using del_timer_sync() inside
> > > ieee80211_free_tid_rx?
> > 
> > Yes, call_rcu() callback can not sleep. Depending of RCU implementation
> > callback can run with bottom half disabled.
> 
> del_timer_sync() doesn't really *sleep* though, even if it waits, so it
> should be fine?

Indeed, I'll change the patch and post officially.

Thanks
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux