Ok, I am able to generate the warnings. It seems that I need to
resolve the first error below, otherwise don't see the subsequent
warnings.
include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.
Will submit patch with different naming since it involves the
rann->metric as well.
Chun-Yeow
On Mon, Mar 19, 2012 at 12:32 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> Hi,
>
>> > You should mark struct ieee80211_rann_ie to contain __le32, so that
>> > sparse will warn about things like this.
>> >
>>
>> I try to change u32 to __le32 for the following members in struct
>> ieee80211_rann_ie.
>>
>> struct ieee80211_rann_ie {
>> u8 rann_flags;
>> u8 rann_hopcount;
>> u8 rann_ttl;
>> u8 rann_addr[6];
>> __le32 rann_seq;
>> __le32 rann_interval;
>> __le32 rann_metric;
>> } __attribute__ ((packed));
>>
>> But when I compile using "make C=2 CF=-D__CHECK_ENDIAN__", I don't see
>> any sparse warning on this.
>
> Not sure, if I make the above change I get:
>
> CHECK net/mac80211/mesh_hwmp.c
> net/mac80211/mesh_hwmp.c:751:17: warning: incorrect type in assignment (different base types)
> net/mac80211/mesh_hwmp.c:751:17: expected unsigned int [unsigned] [usertype] orig_sn
> net/mac80211/mesh_hwmp.c:751:17: got restricted __le32 [usertype] rann_seq
> net/mac80211/mesh_hwmp.c:754:16: warning: incorrect type in assignment (different base types)
> net/mac80211/mesh_hwmp.c:754:16: expected unsigned int [unsigned] [usertype] metric
> net/mac80211/mesh_hwmp.c:754:16: got restricted __le32 [usertype] rann_metric
>
> johannes
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
