Search Linux Wireless

Re: [mac80211] UAPSD: WLAN_STA_PS flag cleared prematurely?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-03-16 at 10:26 +0100, Marco Porsch wrote:
> Hi all,
> 
> in sta_info.c : ieee80211_sta_ps_deliver_response the 
> IEEE80211_TX_STATUS_EOSP is set for all to-be-sent frames, not only for 
> the last. But only the last buffered frame actually gets the EOSP flag.
> 
> 
> /* set EOSP for the frame */
> if (reason == IEEE80211_FRAME_RELEASE_UAPSD &&
>      qoshdr && skb_queue_empty(&frames))
> 	*qoshdr |= IEEE80211_QOS_CTL_EOSP;
> 
> info->flags |= IEEE80211_TX_STATUS_EOSP |
>         IEEE80211_TX_CTL_REQ_TX_STATUS;
> 
> 
> Consequence is, that the WLAN_STA_SP flag gets cleared (multiple times) 
> in ieee80211_tx_status before the last frame with EOSP has been sent.
> Is this correct?

Looks like the bug is above, the EOSP/TX_STATUS should only be set for
the last frame?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux