On Thu, 2012-03-15 at 12:03 -0700, Ben Greear wrote: > >> + list_for_each_entry(sta,&sdata->local->sta_list, list) { > > > > That's not right -- these stats are per netdev so you should only > > aggregate for the netdev, no? > > Ummm, maybe so. I had trouble figuring out how to find > the sta entries that are associated with a netdev, and I'd > like to sum up all station entries for an AP interfaces. > > If you know of any code that uses this, a pointer would > be welcome. Just compare sta->sdata? > >> + BUG_ON(i != STA_STATS_LEN); > > > > That I really don't like much. > > Ok, I'll remove it from a final patch. It catches bugs > in the meantime (miss a comma between strings and > it blows up spectacularly :P). Heh. Some verification would be nice I guess, but I can't really figure out a good way either. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html