On Thu, 2012-03-15 at 11:58 -0400, John W. Linville wrote: > The station_info struct had demanded dBm signal values, but the > cfg80211 wireless extensions implementation was also accepting > "unspecified" (i.e. RSSI) unit values while the nl80211 code was > completely unaware of them. Resolve this by formalling allowing the > "unspecified" units while making nl80211 ignore them. Looks fine, just a minor comment below. > + * @signal: the signal strength, type depends on the wiphy's signal_type > + * @signal_avg: avg signal strength, type depends on the wiphy's signal_type This should be more specific since the BSS signal is "unspec" or "mBm" where this now demands "unspec" or "dBm"... I suppose it could be made more consistent at some point. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html