Hi Wei, Again, a couple of comments On Mon, Mar 12, 2012 at 12:10, wei <yinwei168@xxxxxxxxx> wrote: > From Wei YIN <Wei.Yin@xxxxxxxxxxxx> > Improve PID rate control mechanism by avoiding rate oscillation problem > > Signed-off-by: Wei YIN <Wei.Yin@xxxxxxxxxxxx> > --- > kernel 3.3.0 > net/mac80211/rc80211_pid.h | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+), 0 deletions(-) You shouldn't split this change up into separate files. When I said "this should be in a separate patch" - I meant that the change I was referring to was unrelated to what your patch was about - most of these were minor cleanups or things like that. You should write patches that do one thing and do it properly, and if you find any places that could use work unrelated to that "one thing", those changes should go in a separate patch. Also, this patch looks like it adds all the data structures that the first patch in this series would depend on - this should be part of that patch. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
