On Fri, 2012-03-09 at 10:36 -0800, greearb@xxxxxxxxxxxxxxx wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> This lets the user know which interface has failed
> the check_sdata_in_driver check.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
> :100644 100644 e8960ae... e62e7c3... M net/mac80211/driver-ops.h
> net/mac80211/driver-ops.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/driver-ops.h b/net/mac80211/driver-ops.h
> index e8960ae..e62e7c3 100644
> --- a/net/mac80211/driver-ops.h
> +++ b/net/mac80211/driver-ops.h
> @@ -7,7 +7,11 @@
>
> static inline void check_sdata_in_driver(struct ieee80211_sub_if_data *sdata)
> {
> - WARN_ON(!(sdata->flags & IEEE80211_SDATA_IN_DRIVER));
> + if (unlikely(!(sdata->flags & IEEE80211_SDATA_IN_DRIVER))) {
> + printk(KERN_ERR "%s: Failed check-sdata-in-driver check, flags: 0x%x\n",
> + sdata->dev->name, sdata->flags);
> + WARN_ON(1);
> + }
How about WARN(!(...), ...) instead -- that way the message will be part
of the warning too.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
