Search Linux Wireless

Re: [PATCH 3/5 V2] p54usb: Load firmware from work queue and not from probe routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/09/2012 03:45 PM, Christian Lamparter wrote:
On Friday, March 09, 2012 05:28:57 AM Larry Finger wrote:
Drivers that load firmware from their probe routine have problems with the
latest versions of udev as they get timeouts while waiting for user
space to start. The problem is fixed by loading the firmware and starting
mac80211 from a work queue. By using this method, most of the
original code is preserved.

Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx>
---
Well, I thought this over and I think unless we change the Kconfig
and make the backend modules [p54pci, p54usb and p54spi]
module-only options, we have to go with request_firmware_nowait.

You see, if the p54* modules are compiled into the very bzImage:
The instant workqueue option wouldn't work because the device
might be initialized before the filesystem is. A combo approach
[delayed workqueue, when no userspacehelper is available and a
direct call to request_firmware (when it is availabe)] would
work too, but then we would be reimplementing
request_firmware_nowait ...

Christian,

Your point is well taken. I will rewrite this one. John was holding it for 3.5 anyway.

Do we still want to try for the legacy firmware if the primary is not available?

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux