On 03/07/2012 09:26 PM, Joe Perches wrote: > On Wed, 2012-02-29 at 19:18 +0200, Kalle Valo wrote: >> Fix the issues which checkpatch found and were easy to fix. Especially >> callers of ath6kl_bmi_write() are tricky and that needs to be fixed >> separately. > > Just a trivial note. > >> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c > [] >> @@ -390,7 +390,7 @@ static bool ath6kl_is_valid_iftype(struct ath6kl *ar, enum nl80211_iftype type, >> return false; >> >> if (ar->ibss_if_active || ((type == NL80211_IFTYPE_ADHOC) && >> - ar->num_vif)) >> + ar->num_vif)) > > I think this would be better as: > > if (ar->ibss_if_active || > (type == NL80211_IFTYPE_ADHOC && ar->num_vif)) > > Bundling dependent tests on a single line is sensible. I agree, but I just pushed this patch and I can't change it anymore. I try to remember this in the future. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
