On Wed, Feb 29, 2012 at 07:24:44PM +0100, Felix Fietkau wrote: > On 2012-02-29 7:08 PM, John W. Linville wrote: > > On Mon, Feb 27, 2012 at 07:58:39PM +0100, Felix Fietkau wrote: > >> The approach of this change is flawed, as it triggers tx status processing > >> from more callsites, yet the chips only have one global tx status queue. > >> Subsequent patches will properly fix the issue that this one tried to address. > >> > >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> > > > > How flawed is the current approach? That commit looks like it has been > > around for months already. Does it really _need_ to be fixed in 3.3? > It only slightly reduces the severity of the issue it tried to address, > while adding some ugly race conditions. It is not possible to properly > fix the issue without a revert of that commit, so I really would like to > see this patch series in 3.3. I am happy to take this series for 3.4, but it seems quite late for 3.3. We have been living with it for a while already. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html