Search Linux Wireless

Re: [PATCH 3/3] mac80211: fix mesh airtime link metric estimating

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 2, 2012 at 3:18 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Fri, 2012-03-02 at 15:05 -0800, Thomas Pedersen wrote:
>> Airtime link metric estimation was broken in HT mesh, use
>> cfg80211_calculate_bitrate to get the right rate value.
>
>> -     if (sta->last_tx_rate.flags & IEEE80211_TX_RC_MCS)
>> +     sta_set_sinfo(sta, &sinfo);
>> +     rate = cfg80211_calculate_bitrate(&sinfo.txrate);
>> +     if (WARN_ON(!rate))
>>               return MAX_METRIC;
>
> Patch 1 should be rolled into this, but I don't like it -- you fill a
> lot of info you don't need, I think the rate should be factored out of
> sta_set_sinfo then
>

Yes that would be better.

Thanks,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux