Search Linux Wireless

Re: [PATCH 21/21] cw1200: Kconfig + Makefile for the driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

I fixed most of comments and cleaned up Kconfig a bit, will resubmit the patchset soon.
+config CW1200_BH_DEBUG
+      bool "Enable low-level device communication logs (DEVELOPMENT)"
+      help
+        Say Y if you want to enable BH logs.
+        If unsure, say N.
What does "BH" stand for here? In the kernel it typically stands for
Bottom Half (or softirq) but that can't be meant? In other places in
your code you do mean that though, it seems, so this is a bit confusing.
Well, I see it was a big mistake to call serving thread "bh" :). Starting this project once again I would not do it like that. But it is difficult to rename it all around
the code now, just because the code is published already on Igloo.

You should think about adding tracing instead.
Good point. I added it to TODO list.

Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux