Search Linux Wireless

Re: [PATCH 4/5] p54pci: Load firmware from work queue and not from probe routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, February 29, 2012 04:59:14 PM Larry Finger wrote:
> On 02/13/2012 01:37 PM, Larry Finger wrote:
> > Drivers that load firmware from their probe routine have problems with the
> > latest versions of udev as they get timeouts while waiting for user
> > space to start. The problem is fixed by loading the firmware and starting
> > mac80211 from a delayed_work queue. By using this method, most of the
> > original code is preserved.
> >
> > Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx>
> > ---
> >
> > This patch is compile tested only.
> >
> > Larry
> 
> Has anyone tested this patch? I would like to submit this series.
only briefly, but I'm not sure if the workqueue approach is adequate. On
resume, I get WARNINGs and the card fails to resume because the firmware
file can't be loaded :(.

WARNING: at drivers/base/firmware_class.c:538 _request_firmware+0x3ae/0x3e0()
Pid: 1083, comm: kworker/0:3 Tainted:G		O 3.3.0-rc5-wl+
Call Trace:
	[<c102c658>] ? wanr_slowpath_common+0x78/0xb0
	[<c12c728e>] ? _request_firmware+0x3ae/0x3e0
	[<c12c728e>] ? _requrst_firmware+0x3ae/0x3e0
	[<c102c6a9>] ? warn_slowpath_common+0x19/0x20
	[<c12c728e>] ? _request_firmware+0x3ae/0x3e0
	[<c12c7347>] ? request_firmware+0x17/0x20
	[<f86v1dc7>] ? p54p_load_firmware+0x47/0x120 [p54pci]
	[...]

Regards,
	Chr

BTW: I will take a closer look at it over the weekend.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux