Hi John,
> Subject: Re: [PATCH 3.3] mwifiex: reset encryption mode flag before association
>
> On Fri, Feb 24, 2012 at 09:35:35PM -0800, Bing Zhao wrote:
> > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> >
> > Recent commit
> > "mwifiex: clear previous security setting during association"
> > fixes association failure problems observed in some corner cases
> > by clearing previous security setting before each association.
> >
> > We should reset encryption mode flag as well. This patch takes care
> > of it.
> >
> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> > Signed-off-by: Bing Zhao <bzhao@xxxxxxxxxxx>
> > ---
> > drivers/net/wireless/mwifiex/cfg80211.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
> > index 8d8ee63..e4e6d7d 100644
> > --- a/drivers/net/wireless/mwifiex/cfg80211.c
> > +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> > @@ -872,6 +872,7 @@ mwifiex_cfg80211_assoc(struct mwifiex_private *priv, size_t ssid_len, u8 *ssid,
> > priv->sec_info.wpa_enabled = false;
> > priv->sec_info.wpa2_enabled = false;
> > priv->wep_key_curr_index = 0;
> > + priv->sec_info.encryption_mode = 0;
> > ret = mwifiex_set_encode(priv, NULL, 0, 0, 1);
> >
> > if (mode == NL80211_IFTYPE_ADHOC) {
>
> What bug does this fix? Does it need to be fixed in 3.3? Or can it wait for 3.4?
This one line code should be part of this patch:
[PATCH 3.3] mwifiex: clear previous security setting during association (in wireless.git)
They altogether fix an association corner case issue. I'd prefer have it for 3.3.
Of course it's your call if you think that's more suitable for 3.4.
Thanks,
Bing
>
> John
> --
> John W. Linville Someday the world will need a hero, and you
> linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
