2012/2/25 Hauke Mehrtens <hauke@xxxxxxxxxx>: > On 02/23/2012 10:52 PM, Arend van Spriel wrote: >> +#define BCMA_CC_OTPL 0x001C /* OTP layout */ >> +#define BCMA_CC_OTPL_GURGN_OFFSET 0x00000FFF /* offset of general use region */ >> #define BCMA_CC_IRQSTAT 0x0020 >> #define BCMA_CC_IRQMASK 0x0024 >> #define BCMA_CC_IRQ_GPIO 0x00000001 /* gpio intr */ >> @@ -79,6 +84,10 @@ >> #define BCMA_CC_IRQ_WDRESET 0x80000000 /* watchdog reset occurred */ >> #define BCMA_CC_CHIPCTL 0x0028 /* Rev >= 11 only */ >> #define BCMA_CC_CHIPSTAT 0x002C /* Rev >= 11 only */ >> +#define BCMA_CC_CHIPST_4313_SPROM_PRESENT 1 >> +#define BCMA_CC_CHIPST_4313_OTP_PRESENT 2 >> +#define BCMA_CC_CHIPST_4331_SPROM_PRESENT 2 >> +#define BCMA_CC_CHIPST_4331_OTP_PRESENT 4 >> #define BCMA_CC_JCMD 0x0030 /* Rev >= 10 only */ >> #define BCMA_CC_JCMD_START 0x80000000 >> #define BCMA_CC_JCMD_BUSY 0x80000000 > > What is the correct way to format this file? BCMA_CC_JCMD_BUSY uses two > spaces after the define and BCMA_CC_OTPS_CID_PROTECT uses a tabulator > and a space, what is the correct or intended way to format this? This > does not have directly something to do with this patches as both ways > are currently coded in this file. I tried to use two spaces, I didn't mean to add tabs after "define". If I did, it was done by a mistake. I also used to use hexadecimal numbers for values (like BCMA_CC_CHIPST_4331_OTP_PRESENT): 0x00000004 rather than 4 I don't really have any arguments for that choice, I've just copied ssb (and b43?) coding style. However keeping one styles sounds reasonable. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
