On Thursday, February 23, 2012 04:53:34 PM Nicolas Cavallari wrote: > On Access Point mode, when transmitting a packet, if the destination > station is in powersave mode, we abort transmitting the packet to the > device queue, but we do not reclaim the allocated memory. Given enough > packets, we can go in a state where there is no packet on the device > queue, but we think the device has no memory left, so no packet gets > transmitted, connections breaks and the AP stops working. > > This undo the allocation done in the TX path when the station is in > power-save mode. > > Signed-off-by: Nicolas Cavallari <cavallar@xxxxxx> Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> Cc: stable <stable@xxxxxxxxxxxxxxx> > --- > While this seems to fix my problem, there could still be problems remaining > in this code path. Particularly carl9170_tx_status will do lots of things > like incrementing counters and waking up mac80211 queues... That should be alright. As a rule of thumb, for every call to carl9170_tx_accounting [called by carl9170_op_tx tx handler] we need to call carl9170_tx_status. If the station is still in ps mode, mac80211 will cache the station's frames and sets the TIM bits. > > diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c > index 771e1a9..8d52ddd 100644 > --- a/drivers/net/wireless/ath/carl9170/tx.c > +++ b/drivers/net/wireless/ath/carl9170/tx.c > @@ -1253,6 +1253,7 @@ static bool carl9170_tx_ps_drop(struct ar9170 *ar, struct sk_buff *skb) > atomic_dec(&ar->tx_ampdu_upload); > > tx_info->flags |= IEEE80211_TX_STAT_TX_FILTERED; > + carl9170_release_dev_space(ar, skb); > carl9170_tx_status(ar, skb, false); > return true; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
