Search Linux Wireless

Re: [PATCH 3/6] iwlwifi: cleanup/fix memory barriers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-02-23 at 11:16 +0100, Stanislaw Gruszka wrote:

>  	__iwl_clear_bit(trans, CSR_GP_CNTRL,
>  			CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
> +	/*
> +	 * In above we are reading CSR_GP_CNTRL register, what will flush any
> +	 * previous writes, but still want write, which clear MAC_ACCESS_REQ
> +	 * bit, be performed on PCI bus before any other writes scheduled on
> +	 * different CPUs (after we drop reg_lock).
> +	 */
> +	mmiowb();
>  }

I changed this comment to the, imho, more readable

        /*
         * Above we read the CSR_GP_CNTRL register, which will flush
         * any previous writes, but we need the write that clears the
         * MAC_ACCESS_REQ bit to be performed before any other writes
         * scheduled on different CPUs (after we drop reg_lock).
         */

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux