On Tue, 2012-02-21 at 14:05 +0100, Johannes Berg wrote:
> On Wed, 2012-02-22 at 02:53 +0800, Chun-Yeow Yeoh wrote:
>
> > +++ b/net/mac80211/mesh_hwmp.c
> > @@ -590,12 +590,22 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata,
> > flags = PREQ_IE_FLAGS(preq_elem);
> > preq_id = PREQ_IE_PREQ_ID(preq_elem);
> > hopcount = PREQ_IE_HOPCOUNT(preq_elem) + 1;
> > + if (mpath && mpath->is_root) {
> > + mesh_path_sel_frame_tx(MPATH_PREQ, flags, orig_addr,
> > + cpu_to_le32(orig_sn), target_flags, target_addr,
> > + cpu_to_le32(target_sn), mpath->rann_snd_addr,
> > + hopcount, ttl, cpu_to_le32(lifetime),
> > + cpu_to_le32(metric), cpu_to_le32(preq_id),
> > + sdata);
> > + goto endpreq;
> > + }
> > mesh_path_sel_frame_tx(MPATH_PREQ, flags, orig_addr,
> > cpu_to_le32(orig_sn), target_flags, target_addr,
> > cpu_to_le32(target_sn), broadcast_addr,
> > hopcount, ttl, cpu_to_le32(lifetime),
> > cpu_to_le32(metric), cpu_to_le32(preq_id),
> > sdata);
> > +endpreq:
>
> maybe "else {..." instead of the goto?
actually, since only one parameter is different, it's probably better to
just introduce a local variable for that parameter.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
