On Mon, 2012-02-13 at 15:45 -0600, Larry Finger wrote: > On 02/13/2012 08:13 AM, Johannes Berg wrote: > > config RTLWIFI_DEBUG > > tristate "Additional debugging output" > > depends on RTL8192CE || RTL8192CU || RTL8192SE || RTL8192DE > > default y > > > > should be > > > > config RTLWIFI_DEBUG > > bool "..." > > > > as otherwise > > > > +#ifdef CONFIG_RTLWIFI_DEBUG > > > > can never be true in a modular build. > > > > johannes > > Johannes, > > It is OK as is. The appropriate section of my .config has > > CONFIG_RTL8192CE=m > CONFIG_RTL8192SE=m > CONFIG_RTL8192DE=m > CONFIG_RTL8192CU=m > CONFIG_RTLWIFI=m > CONFIG_RTLWIFI_DEBUG=m Kconfig wise it is fine, but you might as well unset it -- the only use is an #ifdef which will not match when it's set to m. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html