Hi,
Quick query:
On Fri, Feb 10, 2012 at 07:09, Arend van Spriel <arend@xxxxxxxxxxxx> wrote:
> The module_init/exit functions are moved to dhd_linux.c to prepare
> for supporting multiple host interface types.
>
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx>
> Reviewed-by: Franky (Zhenhui) Lin <frankyl@xxxxxxxxxxxx>
> Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx>
> ---
> .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c | 7 +----
> drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h | 6 +++++
> .../net/wireless/brcm80211/brcmfmac/dhd_linux.c | 24 ++++++++++++++++++++
> 3 files changed, 32 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
> index eff0073..ff7fc0e 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
> @@ -1183,3 +1183,27 @@ exit:
> return ret;
> }
> #endif /* DEBUG */
> +
> +static int __init brcmfmac_init(void)
> +{
> + int ret = 0;
> +
> +#ifdef CONFIG_BRCMFMAC_SDIO
> + ret = brcmf_sdio_init();
> + if (ret)
> + goto fail;
> +#endif
I assume that the USB driver init will be added here as a separate #ifdef block.
If this is the case, doesn't this mean that on a system with both the
USB and SDIO drivers enabled in .config, you won't be able to load the
USB driver without the SDIO driver or vice-versa?
The model that most other drivers I've seen use is to have
bus-specific modules and a common code module.
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
