Search Linux Wireless

RE: [PATCH V2] rtlwifi: Return correct failure code on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >   	return 1;
> 
> You must have an extreme memory limitation to find all these problems.
> 

As part of system testing we do

> As long as you are reworking this section, I would prefer you leave
the
> "return
> err" as it is now, change the "return 1" to "return 0", and remove the
> not
> operator in "err = !rtl_pci_init(hw, pdev);" call of this routine. I
> just
> discovered it a few days ago, and it bothers me, but I've been too
busy
> to
> submit a fix. In addition, these changes will convert rtl_pci_init()
> into a more
> normal routine that returns 0 if OK and non-zero on errors.
> 

OK - I'll do that tomorrow and resubmit (hopefully correctly this time!)

> Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux