Search Linux Wireless

Re: [RFC 4/4] iwlwifi: use writeb,writel,readl directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-02-07 at 09:22 +0100, Stanislaw Gruszka wrote:
> On Mon, Feb 06, 2012 at 08:32:52AM -0800, wwguy wrote:
> > I believe iwl driver were use readl/writel before switch to
> > ioread32/iowrite32 (long time ago)
> > 
> > http://www.gossamer-threads.com/lists/linux/kernel/960145
> >
> > also, AFAIK, the readl/writel IO functions still works but their use in
> > new code is discouraged.
> I do not think so, we have tons of drivers that use readl/writel.
> PCI express devices can not use port-based IO, they will be
> incredible slow then.

Agree

> I think confusion come from a fact that iwlwifi use pci_ioremp() for
> mapping registers, which can also maps port-based IO areas. Simply
> changing that into pci_ioremap_bar(), and make driver depend on
> CONFIG_HAS_IOMEM will remove that inconsistency.
> 
> Stanislaw 


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux