On Tue, Jan 31, 2012 at 7:43 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On 1/26/2012 4:37 AM, Victor Goldenshtein wrote: >> >> The dfs master device should monitor radar channels >> for potential radar interference for a minimum of >> CAC (channel availability check) time, during this >> period no tx can occur. If no radar interference >> is detected the dfs master may initiate the tx with >> new NL80211_CMD_DFS_ENABLE_TX command. > > > So do we think that no safeguards here at all are acceptable? Not even > checking that radar detection was enabled, CAC time expired, etc.? We can add a check whether dfs is supported by the driver (rdev->wiphy.features & NL80211_FEATURE_DFS). The nl/cfg/mac doesn't have the info whether the radar detection is enabled and definitely doesn't heard about CAC time, on other hand the driver which starts/handles radar detection know whether it started or not. I think the driver should perform this simple "sanity" checks, otherwise we"ll need to save different DFS states in the mac, not sure that this is what we want. -- Thanks, Victor. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html