On Thu, Feb 02, 2012 at 09:39:36AM +0530, Sujith Manoharan wrote: > Rajkumar Manoharan wrote: > > On Thu, Feb 02, 2012 at 08:38:32AM +0530, Sujith Manoharan wrote: > > > Rajkumar Manoharan wrote: > > > > +void ath_start_rx_poll(struct ath_softc *sc, const u32 msec) > > > > +{ > > > > + if (!AR_SREV_9300_20_OR_LATER(sc->sc_ah)) > > > > + return; > > > > > > I have not reviewed the patch, but to do such workarounds for an entire > > > family of chips is overkill. Has it been confirmed that the other > > > chips falling under this SREV check require this snafu ? > > > > > unfortunately this snafu is applicable for all ar9380 MAC based chips ;) > > and confirmed the same. > > Ok. But this stuff really needs to be verified for other chips. > These 'poll' workarounds are piling up. > Agree. But sometimes these 'poll' WARs are being inevitable. As this patch was verified in ar938x chips, i update the SREV to check only for 938x. -- Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html