On Tue, Jan 31, 2012 at 06:00:09PM +0100, Gertjan van Wingerde wrote:
> > Not only the code is different, but RF_R1 register value we program
> > is different for 30xx and 33xx when chain_num == 1 (changed by
> > RFCSR1_{RX2,TX2)_PD bit).
> >
> > I'm not against merging these two cases and program different values
> > into register than Ralink driver do, but maybe in the next linux
> > release (counting from release of that change), so any breakage
> > eventually caused by that merge could be easily detected.
>
> OK. Indeed let's do this in a different commit, at least. I don't know
> if it has to be a
> different kernel release, as long as we are able to bisect it.
Average users are using only released stuff, so if this patch fix
any practical problem i.e. throughput, and merging code will break
that again, fix and new breakage will stay unnoticed.
> Acked-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx>
>
> for this patch as well.
Thanks
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
