Search Linux Wireless

Re: [PATCH V3] rtlwifi: Convert to asynchronous firmware load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/30/2012 04:45 PM, Larry Finger wrote:
This patch addresses a kernel bugzilla report and two recent mail threads.

The kernel bugzilla report is https://bugzilla.kernel.org/show_bug.cgi?id=42632,
which reports a udev timeout on boot.

The first mail thread, which was on LKML (http://lkml.indiana.edu/hypermail/
linux/kernel/1112.3/00965.html) was for a WARNING that occurs after a
suspend/resume cycle for rtl8192cu.

The scond mail thread (http://marc.info/?l=linux-wireless&m=132655490826766&w=2)
concerned changes in udev that break drivers that delay while firmware is loaded
on modprobe.

This patch converts all rtlwifi-based drivers to use the asynchronous firmware
loading mechanism. Drivers rtl8192ce, rtl8192cu and rtl8192de share a common
callback routine. Driver rtl8192se needs different handling of the firmware,
thus it has its own code.

Signed-off-by: Larry Finger<Larry.Finger@xxxxxxxxxxxx>
Cc: Stable<stable@xxxxxxxxxxxxxxx>
---

V2 - Add check for firmware load callback.
V3 - Removed some debugging code left in by accident.

---

John,

This patch will apply to the wireless-testing git tree.

I have mixed feelings about the timing of the inclusion of this patch.
It is quite invasive, which would normally indicate that it go through
the normal process and ultimately be included in V3.4 to get further
testing. On the other hand, the number of bug reports is growing rapidly,
which argues for it to be included quickly and backported to stable.

I'll leave that decision to you. If you decide to push this to mainline
now, there is one additional complication due to conflicts with the series
of patches by Joe Perches that modified the debug printouts (commits
804dd24 through 07839b1). I have a version of the patch for Linus's tree,
but that pushes the conflicts in a later merge in linux-next.

To improve the testing coverage, I will post the mainline patch at b.k.o,
bug #42632.

Larry
---



d88e0b3162bded8190866d9a17f5e36c9bb0d29e in wireless-testing (which includes 'rtlwifi: Convert to asynchronous firmware load') is working well on my RTL8188CE [10ec:8176].

rtg
--
Tim Gardner tim.gardner@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux