On Mon, 2012-01-30 at 14:28 -0500, John W. Linville wrote: > Anyone looking for a little "janitorial" project to do under the > drivers/net/wireless tree? > > find drivers/net/wireless/ -type f -exec grep -H WARN_ON {} \; | \ > grep -v WARN_ON_ONCE | wc -l > 653 > > That looks like an awful lot of "WARN_ON" calls. Do all of them > really need to SPAM the log files every single time they are hit? > Couldn't a lot of them be WARN_ON_ONCE instead? > > Patches welcome... > > John $ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \ wc -l 280 There are also: $ grep -rP --include=*.[ch] "\bWARN_ON\s*\(" drivers/net/wireless | \ grep "define" drivers/net/wireless/b43legacy/b43legacy.h:# define B43legacy_WARN_ON(x) WARN_ON(x) drivers/net/wireless/b43/b43.h:# define B43_WARN_ON(x) WARN_ON(x) Any reason anyone can think of this shouldn't be a sed conversion? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html