On 28/01/2012 05:39, Johannes Berg wrote: > On 1/26/2012 4:36 AM, Nicolas Cavallari wrote: > >> - if (ifibss->fixed_channel) >> + if (ifibss->fixed_bssid) >> return; >> >> printk(KERN_DEBUG "%s: No active IBSS STAs - trying to scan for >> other " >> "IBSS networks with same SSID (merge)\n", sdata->name); > > Just from the looks of it, this doesn't seem right. If you're fixing the > BSSID, you're still asking for automatic channel selection and merging > with other peers using the same BSSID on different channels, so I > disagree with your commit message quite completely. I didn't know that. In fact, from my understanding of the current source, if you fix the BSSID, you won't merge, period. And even if you don't fix the BSSID, if you found a BSS with the same BSSID but a different channel, you still won't merge. And now, if you are alone and you fixed your channel, you won't try to merge with other BSS in the same channel. If you believe that the condition should be "fixed_bssid && fixed_channel", i can send another patch. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
