On Fri, 2012-01-20 at 10:44 -0800, Sam Leffler wrote: > On Fri, Jan 20, 2012 at 6:17 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > On Thu, 2012-01-12 at 09:53 -0800, Sam Leffler wrote: > > > > > + if (fixed_rate != -1) { > > > + struct ieee80211_channel *chan = local->hw.conf.channel; > > > + struct ieee80211_supported_band *sband = > > > + local->hw.wiphy->bands[chan->band]; > > > + struct ieee80211_tx_rate *rates = info->control.rates; > > > + int i; > > > + > > > + if (fixed_rate_flags & IEEE80211_TX_RC_MCS) { > > > + WARN_ON(!sband->ht_cap.ht_supported); > > > + rates[0].idx = fixed_rate; > > > > Unless I missed something, this would be *trivial* to trigger by > > injection -- doesn't seem like a good idea to me. > > > > Can unprivileged users inject packets? Is your preference to generate > an error or just suppress the warning? I'm not sure, but it doesn't really matter -- even printing an error here is quite pointless. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html