On Thu, Jan 19, 2012 at 2:35 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2012-01-19 at 13:37 +0200, Eliad Peller wrote:
>> On Thu, Jan 19, 2012 at 10:29 AM, Johannes Berg
>> <johannes@xxxxxxxxxxxxxxxx> wrote:
>> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
>> >
>> > Similar to the previous beacon filtering patch,
>> > make CQM RSSI support depend on the flags that
>> > the driver set for virtual interfaces.
>> >
>> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
>> > ---
>> [...]
>>
>> >
>> > - if (!(local->hw.flags & IEEE80211_HW_SUPPORTS_CQM_RSSI)) {
>> > - if (sdata->vif.type != NL80211_IFTYPE_STATION)
>> > - return -EOPNOTSUPP;
>> > - return 0;
>> > - }
>> > -
>> > /* tell the driver upon association, unless already associated */
>> > - if (sdata->u.mgd.associated)
>> > + if (sdata->u.mgd.associated &&
>> > + sdata->vif.driver_flags & IEEE80211_VIF_SUPPORTS_CQM_RSSI)
>> > ieee80211_bss_info_change_notify(sdata, BSS_CHANGED_CQM);
>> >
>> should you return EOPNOTSUPP if the vif doesn't support it?
>
> No. The code above that checks the type is useless as cfg80211 already
> checks the type, and we do support this in software in mac80211 if
> there's no HW offload for it.
>
right. thanks.
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
