Hi Samuel,
> > diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h
> > index 8696b77..d8aef2e 100644
> > --- a/include/net/nfc/nfc.h
> > +++ b/include/net/nfc/nfc.h
> > @@ -66,6 +66,8 @@ struct nfc_ops {
> > #define NFC_TARGET_IDX_ANY -1
> > #define NFC_MAX_GT_LEN 48
> > #define NFC_MAX_NFCID1_LEN 10
> > +#define NFC_MAX_SENSB_RES_LEN 12
> > +#define NFC_MAX_SENSF_RES_LEN 18
> I think those values should be exported to user space though
> include/linux/nfc.h.
> When fetching the byte stream from the netlink socket, you
> usually want
> to check if it has a valid length in order to memcpy it to a static
> array embedded with your target structure.
> Same applies to NFC_MAX_NFCID1_LEN.
Sure, I will move the definitions to include/linux/nfc.h.
> The rest of the code looks fine to me.
>
> Cheers,
> Samuel.
Thanks & BR,
Ilan--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
