On Thu, 2012-01-12 at 21:36 +0100, Antonio Quartulli wrote:
> +static void ieee80211_rx_mgmt_auth_ibss(struct ieee80211_sub_if_data *sdata,
> + struct ieee80211_mgmt *mgmt,
> + size_t len)
> +{
> + u16 auth_alg, auth_transaction;
> + size_t baselen;
> +
> + lockdep_assert_held(&sdata->u.ibss.mtx);
> +
> + if (len < 24 + 6)
> + return;
> +
> + baselen = (u8 *) mgmt->u.auth.variable - (u8 *) mgmt;
> + if (baselen > len)
> + return;
> +
> + auth_alg = le16_to_cpu(mgmt->u.auth.auth_alg);
> + auth_transaction = le16_to_cpu(mgmt->u.auth.auth_transaction);
> +
> + if (auth_alg == WLAN_AUTH_OPEN && auth_transaction == 1) {
negating & return would be easier to read & less indentation
> +#ifdef CONFIG_MAC80211_IBSS_DEBUG
> + printk(KERN_DEBUG "%s: RX Auth SA=%pM DA=%pM BSSID=%pM."
> + "(auth_transaction=%d)\n",
> + sdata->name, mgmt->sa, mgmt->da, mgmt->bssid,
> + auth_transaction);
> +#endif
> + if (sta_info_destroy_addr(sdata, mgmt->sa) != -ENOENT) {
> + ieee80211_ibss_add_sta(sdata, mgmt->bssid, mgmt->sa, 0,
> + false);
> + rcu_read_unlock();
> + }
This doesn't seem to make sense, why not add the station even if we
didn't know about it before?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
