On Tue, Jan 10, 2012 at 12:56 PM, Andreas Hartmann <andihartmann@xxxxxxxxxxxxxxx> wrote: > I think, that there is a problem with the tx status, as if I can see the > BAR in the trace and even the response of the STA (so the BAR was > probably ok), there really seems to be a problem with the tx status. > >> 2) If the same BAR fails consecutively we should maybe really tear down >> the BA session as it was done before >> >> 2 is done in the below untested patch and will also work around 1. >> Mind to give it a try? > > Yes :-) > > The workaround patch works fine for me (at a first glance - I didn't > check for any side effects yet). The stall doesn't happen any more. But > I'm not really sure, why it works: > > At the beginning, you just can see 9 tx failures. This is most likely a complete AMPDU that failed. > After a few tx > failures, you can see 7 BAR's, which are pending, but never passed to > ieee80211_send_bar(). The BAR for each failed AMPDU subframe is sent by mac80211. > - Why are they suddenly ok (are they really ok)? Or is it a logging > problem (too much input at the same time)? > > > At session 38176, you can see your patch at work :-). > > > [27229.720767] rt2800_txdone_entry - tx failed > [27229.720791] rt2800_txdone_entry - tx failed > [27229.720800] rt2800_txdone_entry - tx failed > [27229.720807] rt2800_txdone_entry - tx failed > [27229.720814] rt2800_txdone_entry - tx failed > [27229.720821] rt2800_txdone_entry - tx failed > [27229.720828] rt2800_txdone_entry - tx failed > [27229.720835] rt2800_txdone_entry - tx failed > [27229.727130] rt2800_txdone_entry - tx failed > [27229.727133] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38064> > [27229.734419] rt2800_txdone_entry - tx failed > [27229.734431] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38080> > [27229.741731] rt2800_txdone_entry - tx failed > [27229.741741] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38096> > [27229.749097] rt2800_txdone_entry - tx failed > [27229.749107] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38112> > [27229.758136] rt2800_txdone_entry - tx failed > [27229.758143] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38128> > [27229.765453] rt2800_txdone_entry - tx failed > [27229.765461] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38144> > [27229.771836] rt2800_txdone_entry - tx failed > [27229.771843] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38160> > [27229.779281] rt2800_txdone_entry - tx failed > [27229.779290] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38176> > > [27229.779315] ieee80211_check_pending_bar -> ieee80211_send_bar() retry cnt: 2 tid: 0 failed_bar_ssn: 38176 > [27229.786705] rt2800_txdone_entry - tx failed > [27229.786714] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38176> > [27229.793439] ieee80211_check_pending_bar -> ieee80211_send_bar() retry cnt: 1 tid: 0 failed_bar_ssn: 38176 > > [27229.793452] ieee80211_check_pending_bar -> ieee80211_stop_tx_ba_session() retry cnt: 0 tid: 0 failed_bar_ssn: 38176 > > [27229.793476] Tx BA session stop requested for 00:25:9c:11:22:33 tid 0 > [27229.802082] Stopping Tx BA session for 00:25:9c:11:22:33 tid 0 > > [27229.807455] rt2800_txdone_entry - tx failed > [27229.807465] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <38176> > > [27229.816023] Open BA session requested for 00:25:9c:11:22:33 tid 0 > [27229.834077] activated addBA response timer on tid 0 > [27229.835517] switched off addBA timer for tid 0 > [27229.835522] Aggregation is on for tid 0 > > > > The following test is done with reduced debugging (without the tx > failed entries). But I can see the set_bar_pending calls without a > send_bar, too. This block is typical and comes up about 6 times a > minute (not regularly). > > [29007.375460] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4000> > [29007.384394] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4016> > [29007.391329] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4032> > [29007.398646] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4048> > [29007.409470] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4064> > [29007.415295] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4080> > [29007.425943] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4096> > [29007.439950] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4112> > [29007.440041] ieee80211_check_pending_bar -> ieee80211_send_bar() retry cnt: 2 tid: 0 failed_bar_ssn: 4112 > [29007.440061] ieee80211_check_pending_bar -> ieee80211_send_bar() retry cnt: 1 tid: 0 failed_bar_ssn: 4112 > [29007.440071] ieee80211_check_pending_bar -> ieee80211_stop_tx_ba_session() retry cnt: 0 tid: 0 failed_bar_ssn: 4112 > [29007.440100] Tx BA session stop requested for 00:25:9c:11:22:33 tid 0 > [29007.447797] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4112> > [29007.449024] Stopping Tx BA session for 00:25:9c:11:22:33 tid 0 > [29007.461327] status.c ieee80211_tx_status() calls ieee80211_set_bar_pending. tid: <0> control: <4> ssn: <4112> > [29007.490023] Open BA session requested for 00:25:9c:11:22:33 tid 0 > [29007.499048] activated addBA response timer on tid 0 > [29007.504198] switched off addBA timer for tid 0 > [29007.504203] Aggregation is on for tid 0 The BAR will only be resent after the next successful AMPDU transmission. And if this BAR transmission fails 3 times the session will be shut down (and restarted later). So this looks good to me although the broken tx status for BAR frames is for sure a rt2800pci problem (or even a hw issue). Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
