On 01/09/2012 09:45 AM, Thirumalai wrote: > Add apsd_info in necessary places to indicate which > AC's uAPSD is enabled. > > A bit is added in the wmi header (bit 4 of info3) > to specify uapsd trigger in rx direction (target to host) > and end of service period in tx direction (host to target) > > Signed-off-by: Thirumalai <tpachamu@xxxxxxxxxxxxxxxx> [...] > +static inline void wmi_data_hdr_set_more_bit(struct wmi_data_hdr *dhdr) > +{ > + dhdr->info |= (WMI_DATA_HDR_MORE_MASK << WMI_DATA_HDR_MORE_SHIFT); > +} > + > +static inline void wmi_data_hdr_set_eosp_bit(struct wmi_data_hdr *dhdr) > +{ > + dhdr->info3 |= (WMI_DATA_HDR_EOSP_MASK << WMI_DATA_HDR_EOSP_SHIFT); > +} I only see one caller for these functions so it's better to copy the code to the caller directly and not have any extra functions. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html