Hi Joe, On 01/05/2012 06:38 PM, Joe Perches wrote: > On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote: > >> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c > [] >> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...) > [] >> + ath6kl_printk(KERN_DEBUG, "%pV", &vaf); > [ >> diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h > [] >> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...); > > You need to add > > __printf(2, 3) > > to the prototype. > > If it's not there, the printf formats and arguments aren't verified. > %pV could do the wrong/bad things. Nice, I'll add that to v3. Thanks again. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
