On Mon, Jan 02, 2012 at 06:33:15PM +0200, Kalle Valo wrote: > On 12/29/2011 12:35 PM, Vasanthakumar Thiagarajan wrote: > > 1. In ath6kl_add_new_sta(), if (ielen <= ATH6KL_MAX_IE) is going to be > > always true due to ielen being u8 and is checked against 256. > > > > 2. In ath6kl_reset_device(), since control can never reach switch..case > > when the target_type is neither TARGET_TYPE_AR6003 nor TARGET_TYPE_AR6004, > > remove the default option of switch statement. > > Two separate patches, please. Ok, I split the patch. > > > @@ -62,8 +62,7 @@ static void ath6kl_add_new_sta(struct ath6kl *ar, u8 *mac, u16 aid, u8 *wpaie, > > > > sta = &ar->sta_list[free_slot]; > > memcpy(sta->mac, mac, ETH_ALEN); > > - if (ielen <= ATH6KL_MAX_IE) > > - memcpy(sta->wpa_ie, wpaie, ielen); > > + memcpy(sta->wpa_ie, wpaie, ielen); > > And then someone changes the u8 ielen to something else and accidentally > adds a bug. I would prefer to have an explicit check for the ielen to > make it obvious what's the maximum length. > > I don't really like using u8 for ielen either. IMHO size_t or similar > would be better. The length of any IE is 1 byte, u8 is the appropriate one. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
