On 2012-01-02 3:06 PM, Mohammed Shafi Shajakhan wrote: > hi Felix, > > > On Monday 02 January 2012 07:11 PM, Felix Fietkau wrote: >> On 2012-01-02 2:13 PM, Mohammed Shafi Shajakhan wrote: >>> From: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx> >>> >>> make use of the already available function 'ar9003_calc_ptr_chksum' >>> in 'ar9003_set_txdesc' >>> >>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@xxxxxxxxxxxxxxxx> >> NACK. I intentionally did not use that function to avoid unnecessary >> access to uncached memory (for performance reasons). > > please explain how it effects the performance and will it cause a > significant impact I don't have any exact numbers anymore, but it was visible enough in the oprofile stats to justify a little functional duplication of code. Eventually this duplication can go away if I can change the ar9003_hw_set_desc_link function to incrementally fix up the checksum instead of recalculating it, which would make the code even more efficient. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
