Search Linux Wireless

Re: [PATCH] wl12xx: Fix power control for CONFIG_RUNTIME_PM off configurations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2011-12-22 07:39, Ohad Ben-Cohen wrote:
-       /* Tell PM core that we don't need the card to be powered now */
-       pm_runtime_put_noidle(&func->dev);
+       /* Power off as we don't need the card to be powered now */
+       wl12xx_sdio_power_off(func);

This in particular looks wrong.

You bypass runtime PM by manipulating the power state of the card
directly, and as a result you leave the runtime PM state out of sync
with the real power state of the device.

Even without my changes we will call wl12xx_sdio_power_on/off for every ifconfig up/down. Is that also a problem or is that case different?

//Pontus
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux