On Wed, Dec 21, 2011 at 06:47:13PM +0100, Arend van Spriel wrote: > On 12/15/2011 12:29 PM, Dan Carpenter wrote: > > Smatch still complains about the brcm driver. Could you take a look at > > these messages? It's mostly just cleanups like doing the correct cast > > for min_t() or handling the default cases on switch statements etc or > > verifying that we broke out of a loop instead of coming to the end > > without finding what we were looking for. > > As promised I took a look at the smatch complaints. > > > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1710 wlc_phy_txpower_reg_limit_calc(50) error: potential null derefence 'txpwr_ptr1'. > > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1719 wlc_phy_txpower_reg_limit_calc(59) error: potential null derefence 'txpwr_ptr2'. > > However, I am not sure about these two. Reading the code these seem > false positives. Could you confirm or correct me on these. Yes. You're obviously right. regards, dan carpenter
Attachment:
signature.asc
Description: Digital signature
