On Wed, 2011-12-21 at 16:14 +0100, Johannes Berg wrote: > On Wed, 2011-12-21 at 13:10 +0200, Luciano Coelho wrote: > > > > ath-$(CONFIG_ATH_DEBUG) += debug.o > > > +ccflags-y += -D__CHECK_ENDIAN__ > > > > Doesn't this force everyone who compiles the modules (even > > non-developers) to have sparse installed? Is it really what we want? > > No. It just forces everyone who does use sparse to also use it for > endian checks. I do the same in all code I maintain, take a look :-) Ah, I get it now. sparse will only run if C=[12] is passed in the make command. I'll probably add the same in wl12xx. It would be nice to have a way to enforce developers to run sparse. Maybe public humiliation works, but it's not the most efficient way. :) -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
