On Thu, Dec 15, 2011 at 03:58:32PM +1100, Julian Calaby wrote:
> > diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
> > index 390797d..783559c 100644
> > --- a/drivers/net/wireless/ath/ath9k/Makefile
> > +++ b/drivers/net/wireless/ath/ath9k/Makefile
> > @@ -10,6 +10,8 @@ ath9k-$(CONFIG_ATH9K_RATE_CONTROL) += rc.o
> > ath9k-$(CONFIG_ATH9K_PCI) += pci.o
> > ath9k-$(CONFIG_ATH9K_AHB) += ahb.o
> > ath9k-$(CONFIG_ATH9K_DEBUGFS) += debug.o
> > +ath9k-$(CONFIG_ATH9K_DEBUGFS) += dfs_debug.o
>
> Shouldn't this config variable be CONFIG_ATH9K_DFS_DEBUGFS?
Yeap!
> You introduce that config variable but never use it.
Good catch.
> > +ath9k-$(CONFIG_ATH9K_DFS_CERTIFIED) += dfs.o
> >
> > obj-$(CONFIG_ATH9K) += ath9k.o
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/dfs_debug.h b/drivers/net/wireless/ath/ath9k/dfs_debug.h
> > <etC>
> > +
> > +#if defined(CONFIG_ATH9K_DEBUGFS)
>
> Same here.
>
> > +
> > +#define DFS_STAT_INC(sc, c) (sc->debug.stats.dfs_stats.c++)
> > +void ath9k_dfs_init_debug(struct ath_softc *sc);
> > +
> > +#else
> > +
> > +#define DFS_STAT_INC(sc, c) do { } while (0)
> > +static inline void ath9k_dfs_init_debug(struct ath_softc *sc) { }
> > +
> > +#endif /* CONFIG_ATH9K_DEBUGFS */
>
> And here =)
Thanks for the review, I just submitted a v2.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
