On Thu, Dec 15, 2011 at 6:00 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2011-12-15 at 17:30 +0100, Helmut Schaa wrote: >> just noticed a problem with QoS frames in AP mode when mac80211 >> relays for example a VOIP frame from STA1 to STA2 the frame will be >> sent out on AC_BE and not on AC_VO. > > Hm. You want (T)DLS ;-) Would be nice but if the clients don't support it we're out of luck :) >> Unfortunately we don't have an skb priority between 256 and 263 and >> we don't have skb->protocol set to ETH_P_IP here since we've just set >> it to ETH_P_802_3. >> >> I tried using eth_type_trans on the frame but that will "pull" the ethernet >> header and adding an skb_push afterwards seems a little bit ugly to me. >> >> Is it possible to just shortcut the classification if the priority is >> already set? >> Or should we just add 256 to the priority before sending the frame to >> dev_queue_xmit? >> >> What would be an appropriate fix for this? > > The >= 256 is already a shortcut, so just adding 256 seems reasonable? Haven't tried that yet but I guess this works. However, if a client is misbehaving and sending low priority frames with a high priority TID we might want to re-classify the frame before sending to its destination? Not sure though. Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
