Search Linux Wireless

Re: [PATCH] b43: avoid calling bcma_* if CONFIG_B43_BCMA is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/12/14 John W. Linville <linville@xxxxxxxxxxxxx>:
> Avoids this:
>
> ERROR: "bcma_chipco_pll_write" [drivers/net/wireless/b43/b43.ko] undefined!
>
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> ---
> It looks like phy_lcn.c could use some bits like this as well...
>
>  drivers/net/wireless/b43/phy_n.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
> index 6b95fd2..154f97d 100644
> --- a/drivers/net/wireless/b43/phy_n.c
> +++ b/drivers/net/wireless/b43/phy_n.c
> @@ -4048,6 +4048,7 @@ int b43_phy_initn(struct b43_wldev *dev)
>  /* http://bcm-v4.sipsolutions.net/802.11/PmuSpurAvoid */
>  static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
>  {
> +#ifdef CONFIG_B43_BCMA
>        struct bcma_drv_cc *cc = &dev->dev->bdev->bus->drv_cc;

Oops, after a moment it doesn't look good. Nack.

We can't unconditionally touch bdev in phy_n, this code can also be
executed for SSB based card. We need "ifdef" plus
switch (dev->dev->bus_type) {

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux