On Tue, Dec 13, 2011 at 13:27, Eliad Peller <eliad@xxxxxxxxxx> wrote:
> Use the newly introduced ieee80211_free_txskb() instead
> of dev_kfree_skb() for failed tx packets.
>
> Reported-by: Arik Nemtsov <arik@xxxxxxxxxx>
> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
> ---
> drivers/net/wireless/wl12xx/main.c | 2 +-
> drivers/net/wireless/wl12xx/tx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index 2f7bfa8..333bc29 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
[..]
>
> diff --git a/drivers/net/wireless/wl12xx/tx.c b/drivers/net/wireless/wl12xx/tx.c
> index 36eb0d6..fe62f21 100644
> --- a/drivers/net/wireless/wl12xx/tx.c
> +++ b/drivers/net/wireless/wl12xx/tx.c
> @@ -740,7 +740,7 @@ void wl1271_tx_work_locked(struct wl1271 *wl)
> set_bit(WL1271_FLAG_FW_TX_BUSY, &wl->flags);
> goto out_ack;
> } else if (ret < 0) {
> - dev_kfree_skb(skb);
> + ieee80211_free_txskb(wl->hw, skb);
Technically, the skb can be a dummy packet here. In this case we
shouldn't do anything. This was a bug before, but it's even more of a
bug now.
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
