On Mon, 2011-12-12 at 15:04 +0200, Eliad Peller wrote: > The ip address of the vif can be set even before the > vif is up. requiring the vif to be up in the vif > notifier makes the notifer ignore this event, which > causes wrong arp filter configuration later on. > > Reported-by: Eyal Shapira <eyal@xxxxxxxxxx> > Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> > --- > net/mac80211/main.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/net/mac80211/main.c b/net/mac80211/main.c > index 8022c62..ad8f712 100644 > --- a/net/mac80211/main.c > +++ b/net/mac80211/main.c > @@ -436,9 +436,6 @@ static int ieee80211_ifa_changed(struct notifier_block *nb, > sdata = IEEE80211_DEV_TO_SUB_IF(ndev); > bss_conf = &sdata->vif.bss_conf; > > - if (!ieee80211_sdata_running(sdata)) > - return NOTIFY_DONE; > - Ok ... maybe a comment would be good when we check associated that if associated the interface has to be up? Otherwise casual readers might wonder if this can call into the driver while it's down? Dunno... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
