Search Linux Wireless

Re: [PATCH 01/15] iwlwifi: add uCode version information support by testmode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Guy, Wey-Yi" <wey-yi.w.guy@xxxxxxxxx> writes:

> On Sat, 2011-12-10 at 08:10 -0800, Kalle Valo wrote:
>> Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> writes:
>> 
>> > From: Hsu, Kenny <kenny.hsu@xxxxxxxxx>
>> >
>> > Create new tm command to report uCode version to userspace
>> > - IWL_TM_CMD_APP2DEV_GET_FW_VERSION
>> 
>> Why not use wiphy.fw_version which is specifally meant for this purpose?
>> 
>
> fw_version is being formatted to string. we need u32

If the u32 format is so important (and I suspect it isn't, most likely
you have string format for your version numbers as well) you can always
format the u32 to hex, for example "0xdeadbeef".

Sure, it's ugly but still less ugly than having a private interface in
the driver. The idea of nl80211 testmode is NOT to replicate wext
private interface.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux